search

meilisearch / milli

Search engine library for Meilisearch ⚡️
MIT License
464 stars 81 forks source link

Fix ShellCheck errors #688

Closed azzamsa closed 1 year ago

azzamsa commented 2 years ago

Hi.

I am running ShellCheck against the shell scripts and fixed the warnings in the PR below:

If that's okay, I plan to add the ShellCheck action check in the CI.

curquiza commented 2 years ago

Hello @azzamsa Thanks for the PR!

Also, we would rather not have this additional CI, we don't change the script + we plan to reorganize this repo in the near future. But thanks for the suggestion 😊

curquiza commented 1 year ago

Closing this due to lack of answer on the PR, of course feel free to reopen if needed 😊

azzamsa commented 1 year ago

Also, we would rather not have this additional CI, we don't change the script + we plan to reorganize this repo in the near future. But thanks for the suggestion blush

Thanks for your patience. Just returned from vacation. It is okay 🙂. I will look for other part to contribute.