meilisearch / milli

Search engine library for Meilisearch ⚡️
MIT License
464 stars 81 forks source link

Fix Facet Indexing bugs #696

Closed loiclec closed 1 year ago

loiclec commented 1 year ago
  1. Handle keys with variable length correctly

Closes (partially) https://github.com/meilisearch/meilisearch/issues/3042 This issue is now easily reproducible with the updated fuzz tests, which now generate keys with variable lengths.

  1. Prevent adding facets to the database if their encoded value does not satisfy valid_lmdb_key.

Closes (partially) https://github.com/meilisearch/meilisearch/issues/2743 This fixes an indexing failure when a document had a filterable attribute containing a value whose length is higher than ~500 bytes. For now, this fix is just meant to prevent crashes. Better handling of long values of filterable attributes will be handled in a separate PR.

bors[bot] commented 1 year ago

Build succeeded: