meilisearch / vuepress-plugin-meilisearch

Add a relevant and typo tolerant search bar to your VuePress
MIT License
63 stars 14 forks source link

fix: include `assets/search.svg` in npm release #253

Closed TonyRL closed 1 year ago

TonyRL commented 2 years ago

Pull Request

What does this PR do?

Fixes asset/search.svg being excluded from npm release.

Steps to reproduce

  1. Follow the official guide to add the plugin
  2. Run yarn docs:build
  3. Expect the following error messages
    (undefined) ./node_modules/vuepress-plugin-meilisearch/MeiliSearchBox.vue?vue&type=style&index=0&id=512bb40d&prod&lang=stylus& (./node_modules/mini-css-extract-plugin/dist/loader.js!./node_modules/css-loader/dist/cjs.js??ref--13-oneOf-1-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/src??ref--13-oneOf-1-2!./node_modules/stylus-loader??ref--13-oneOf-1-3!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/vuepress-plugin-meilisearch/MeiliSearchBox.vue?vue&type=style&index=0&id=512bb40d&prod&lang=stylus&)
    Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
    ModuleNotFoundError: Module not found: Error: Can't resolve './assets/search.svg'

PR checklist

Please check if your PR fulfills the following requirements:

Thank you so much for contributing to Meilisearch!

bidoubiwa commented 1 year ago

My bad, I forgot to merge this

bidoubiwa commented 1 year ago

bors merge

meili-bors[bot] commented 1 year ago

Build succeeded: