meinaart / cypress-plugin-snapshots

Plugin for snapshot tests in Cypress.io
MIT License
497 stars 118 forks source link

Cypress Peer Dependency #183

Closed vipin705 closed 1 year ago

vipin705 commented 3 years ago

will the Cypress Peer Dependency get update? i see its still on 4.5.0 which is very old.

Izhaki commented 3 years ago

We get:

▶ npm audit fix
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @webpoker/tools@0.0.2
npm ERR! Found: cypress@5.2.0
npm ERR! node_modules/cypress
npm ERR!   dev cypress@"5.2.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer cypress@"^4.5.0" from cypress-plugin-snapshots@1.4.4
npm ERR! node_modules/cypress-plugin-snapshots
npm ERR!   dev cypress-plugin-snapshots@"^1.4.4" from the root project

Although the plugin clearly works with cypress@5.2.0. I would submit a PR to change the peer dependency to change the peer dependency to:

  "peerDependencies": {
    "cypress": ">=4.5.0"
  },

But I don't know if this plugin works with cypress versions higher than 5.2

vipin705 commented 3 years ago

i am on "cypress": "^7.1.0" and it works fine locally on my machine.

vipin705 commented 3 years ago

@meinaart when can we expect this to be merged and published ?

vipin705 commented 3 years ago

has this fix been released?

sgromkov commented 3 years ago

🤕 I'm also waiting for this Fix.

agriboz commented 3 years ago

you may want to try npm install "git://github.com/Izhaki/cypress-plugin-snapshots.git#fix-cypress-peer-dependency" --save

ozkoidi commented 2 years ago

Any news on this? I just got the error with Cypress 9.5.1

image

david-renner-dwg commented 2 years ago

@ozkoidi were you ever able to resolve that issue from your screenshot?