meinaart / cypress-plugin-snapshots

Plugin for snapshot tests in Cypress.io
MIT License
497 stars 117 forks source link

Cypress 3.1.5 and list cypress-plugin-snapshots 1.2.5 update snapshots not working. #29

Closed renelux closed 5 years ago

renelux commented 5 years ago

With the above combination snapshots are not being updated when the setting is set to true, removing the image running the spec works fine.

meinaart commented 5 years ago

Are you sure it's not updated on disc? There is a severe caching issue with snapshots that I need to fix. Perhaps it only seems to be not working?

Although this issue should not occur with images. Just want to get all the info needed to fix the bug.

renelux commented 5 years ago

I didn't have time yet to dig deeper and see where it goes wrong, but at the moment it is not working for us at all.

I will try to do a deeper dive and see if I can find the root cause.

renelux commented 5 years ago

We had a local environment issue (docker was not loading the latest code) that resulted in the images not being updated.

We did stumble on a small bug which we fixed in this PR https://github.com/meinaart/cypress-plugin-snapshots/pull/31