search

meinaart / cypress-plugin-snapshots

Plugin for snapshot tests in Cypress.io
MIT License
497 stars 117 forks source link

remove unused dependencies #60

Closed lukeapage closed 4 years ago

lukeapage commented 5 years ago

I couldn't work out why these were present? but maybe there is a reason...

meinaart commented 5 years ago

I think these are needed for socket.io to behave correctly. Especially the uws one. I would need to do a manual test to see if it would still work.

lukeapage commented 4 years ago

It appears to work fine on windows without uws The documentation suggests uws is only required if the wsEngine property overrides the websocket type and I can't find anywhere in cypress-plugin-snapshots that does that: https://github.com/socketio/engine.io#methods-1

meinaart commented 4 years ago

Merged via #98.