Closed kmsauter closed 4 years ago
Nice one! This fixes my issue too #68 !
Thanks for putting this together - also really handy the new ui where you can select different modes 💪
Hello @meinaart, when are you going to merge this? @kmsauter did a great job, and it is working well...
Closed because this is implemented in pull request #79 instead.
I was having a few issues with the update snapshot functionality, sometimes I would click the "Compare snapshots" button but the modal wouldn't open and other times I would click the "Update snapshot" button and again, nothing would happen. I'm not 100% sure but I think the issue might have something to do with Cypress' task runner - I think it's related to the bug mentioned in assets/script.js (i.e. Bug:
cy.readFile
only works first time, as a fix I wrap it in a cachedCypress.Promise
.) I refactored how this functionality is implemented and was able to resolve the issue I was seeing, as well as eliminated the need for the snapshot server, I removed the socket dependencies, wasn't sure if any of the other dependencies were used only by the server and could be removed as well. I also updated initCommands to only set up UI when run in browser.I made a few updates to the UI as well: