search

meinardmueller / synctoolbox

Sync Toolbox - Python package with reference implementations for efficient, robust, and accurate music synchronization based on dynamic time warping (DTW)
https://meinardmueller.github.io/synctoolbox
Other
112 stars 12 forks source link

Estimate tuning #26

Closed xistva02 closed 11 months ago

xistva02 commented 1 year ago

Hello Audio Labs! :)

I just wanted to report a small detail I encountered while using synctoolbox. The function estimate_tuning in synctoolbox.feature.utils should output float based on the function definition but it technically always returns int (number of cents), is that correct? Should it be changed to an integer?

I encountered it while using the function audio_to_pitch_features from synctoolbox.feature.pitch – one of its input arguments is the tuning_offset (it should be integer) but the estimate_tuning function returns float.

This makes no real difference, it is just an implementation detail :)

Have a nice day!

Matej Istvanek

yiitozer commented 11 months ago

Dear @xistva02,

Thank you very much for your query and attention to the details :)

With the commit b1d9e82d88a6ec4eb6a80a889015c127af733a9b, we have resolved this issue.