conflicting plugin with slimefun

[jordanwilliams1]

Describe the bug Slime fun heads will break when you drop them if this plugin is installed.

To Reproduce Steps to reproduce the behavior, for example:

1. Install Slimefun and CS-CORE lib.
2. Get a Slimefun 'HEAD' /SF CHEAT
3. Drop it on the floor, it breaks

Expected behavior It should not break any heads. Tested on 1.13 & 1.14.4

[jordanwilliams1]

Here's my test server if you just want to do a quick test, Should speed it up for you. https://mega.nz/#!kdtmkCjL!LFy3ouJS88Nryi575FU8tSV-Wva5qyfqcRcdooeRaxw

[crashdemons]

I will test this soon but I wanted to provide some more immediate support:

If you disable fixdroppedheads then PlayerHeads will avoid automatically converting these heads when dropped as items. The downside of doing this is PlayerHeads custom heads will also not retain their name/lore when broken by pistons or water (but they will still be detected by right-clicks or API types).

However, this setting does not change the behavior when a head-block is broken. Head-block breaking attempts to determine/ignore if the head is a custom-head by it having no owner username. If Slimefun sets a username for its custom heads, PH will assume it belongs to a player.

[I'm assuming at this time that this is the issue here, but I will need to confirm first.]

Obviously this is not ideal behavior, but the only way to avoid this really is for me to add a blacklist of head names/uuids from other plugins that PH should ignore. (without linking to those plugins and integrating with each).

[crashdemons]

I've tested and after analyzing the issue I've made some changes.

Please try the following development build, which tries to ignore "CSCoreLib" heads when it encounters them. (ignoring by UUID is not easily done, since each Slimefun item has a different UUID it seems - they are ignored by name instead) This should not require you to change settings, regardless of the above post.

https://ci.meme.tips/job/PlayerHeads-5.2/2/

[crashdemons]

@crashdemons How do you disable fixdroppedheads? I Don't see a config option

you shouldn't need to with 5.2.3 but if you still want to there should be a configuration option if your config is recent. you can add it directly to the config as fixdroppedheads: false or using /ph config set fixedroppedheads false ingame.

Description from the default config: link Default config value: link

Sorry for the delayed response, I didn't see your reply when I posted.

[crashdemons]

Let me know how testing goes with the new version when you have a chance. I'm not able to reproduce the issue on the new version, personally.

Thanks.

[jordanwilliams1]

@crashdemons Yes it's fixed.

[crashdemons]

alright. marking as fixed by commits 3fcb0a84707e0f279bab779193909e52e45ed438 and 49b6b1214cecc38f34e77fabe1e46aa45a596221