search

meiskam / PlayerHeads

Bukkit Plugin - Drops a player's head when s/he dies, also mob heads
https://dev.bukkit.org/projects/player-heads
Other
16 stars 39 forks source link

Add mob spawner config option #25

Closed TerdyTheTerd closed 3 years ago

TerdyTheTerd commented 3 years ago

Describe the solution you'd like Add a config option to not drop mob heads from mobs that were spawned from a mob spawner. This is to prevent mob heads from losing rarity easily with mob spawner farms, especially when using SilkSpawners or other such plugins.

Additional context CreatureSpawnEvent store PersistentData via PersistentDataContainer class from Spigot-API if spawn reason is SPAWNER. EntityDeathEvent check for PersistentData key that was set, return if set

I was implementing this myself, but I honestly cannot for the LIFE of me, get maven to behave and get spigot api added correctly. Build always fails because it cannot find the methods used in the above mentioned class.

crashdemons commented 3 years ago

noting your downstream issue crashdemons/PlayerHeads#77

TerdyTheTerd commented 3 years ago

Closing as this was implemented downstream I believe?

crashdemons commented 3 years ago

implemented, but hasn't been rigorously tested.