Open fabian-s opened 1 month ago
Thanks for flagging this! My apologies that I did not check the vignette properly. You are right that a pre-compiled vignette is prone to issues like this. I think I decided to precompile the vignette because it took around 10-20 minutes to build. Do you think it is an acceptable length of time? The old precompiled version (without the covariate section) did pass the CRAN test when I submitted it.
I think I decided to precompile the vignette because it took around 10-20 minutes to build. Do you think it is an acceptable length of time?
Not sure -- CRAN policies just say:
Checking the package should take as little CPU time as possible, as the CRAN check farm is a very limited resource and there are thousands of packages. Long-running tests and vignette code can be made optional for checking, but do ensure that the checks that are left do exercise all the features of the package. [...] Examples should run for no more than a few seconds each: they are intended to exemplify to the would-be user how to use the functions in the package.
I think it's fine to use pre-compiled for a CRAN submission, but would not recommend it in your development-version on GH.
Okay that makes sense. Thanks for this. Will push the changes shortly!
Have replaced the pre-compiled vignette with the actual rmd for building the vignette. This passed the CRAN check.
DESCRIPTION
: YourSuggests:
should include all packages likefields
andevd
that are used in your vignettesVignette does not currently include a properly executed example for including covariates:
https://github.com/meixichen/SpatialGEV/blob/61466b5dde6e5f36965f2244fd8034224076cac3/vignettes/SpatialGEV-vignette.Rmd#L314C1-L340C1 is all just error messages?
R CMD check
--as-cran does not pass:linking openjournals/joss-reviews#6878