search

meizhong986 / WhisperJAV

MIT License
35 stars 7 forks source link

number of lines has decreased #9

Open classmate01 opened 1 month ago

classmate01 commented 1 month ago

Hello! I Just noticed after the latest update, the number of lines I am getting has decreased, not sure about the others...

meizhong986 commented 4 weeks ago

Can you check what is your VAD Threshold?

On Tue, Oct 29, 2024 at 10:48 PM classmate01 @.***> wrote:

Hello! I Just noticed after the latest update, the number of lines I am getting has decreased, not sure about the others...

— Reply to this email directly, view it on GitHub https://github.com/meizhong986/WhisperJAV/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDME2BSVFX4U5UR75K36C4LZ6AGDHAVCNFSM6AAAAABQ24NLJKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDENBWHE3DENI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

classmate01 commented 4 weeks ago

I use the default 0.35 and using WhisperJAV_v0_7b

meizhong986 commented 4 weeks ago

Yes it seems that your observation is correct. Since the last update (ca. a week ago) the code started to use the latest VAD update which is the Silero VAD 0.51 version. That version of VAD doesn't perform well with typical JAV movies: noise and music. May I ask if you're using WhipserJAV for JAV or non-JAV movies?

On Thu, Oct 31, 2024 at 3:45 AM classmate01 @.***> wrote:

I use the default 0.35 and using WhisperJAV_v0_7b

— Reply to this email directly, view it on GitHub https://github.com/meizhong986/WhisperJAV/issues/9#issuecomment-2448957340, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDME2BXM2L3D2PKZWCCGGWLZ6GRWHAVCNFSM6AAAAABQ24NLJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYHE2TOMZUGA . You are receiving this because you commented.Message ID: @.***>

classmate01 commented 4 weeks ago

I'm using it for JAV movies. Should I adjust the VAD threshold to match up with Silero's VAD v0.51?

Thank you for your follow-up and I really appreciate it!

meizhong986 commented 4 weeks ago

That won't help in this situation. The problem is that the new Silero VAD 5x releases are suited for podcasts and other clean speech audio. Better solution is to fix it inside WhisperJAV by using the older release of Silero. I'll look into it

On Thu, Oct 31, 2024 at 4:06 PM classmate01 @.***> wrote:

I'm using it for JAV movies. Should I adjust the VAD threshold to match up with Silero's VAD v0.51?

Thank you for your follow-up and I really appreciate it!

— Reply to this email directly, view it on GitHub https://github.com/meizhong986/WhisperJAV/issues/9#issuecomment-2450258438, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDME2BSLBZJNTG7DPLTH4BDZ6JIPFAVCNFSM6AAAAABQ24NLJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGI2TQNBTHA . You are receiving this because you commented.Message ID: @.***>

meizhong986 commented 4 weeks ago

I just pushed a new update to force using SileroVAD 4.0 version. Give it a try now, let me know.

classmate01 commented 4 weeks ago

I believe its now working!! Thank you so much!