Closed halvors closed 9 years ago
Please merge this, or fix it in some other way. This is really killing a lot of servers...
I'll fix it when I'm able but I have 2 exams in the next 24 hours so I'm very busy at the moment
Ok, understand that :) Good luck with your exams :)
I wish you luck in fixing it in a not-crutch way.
The pull-request would require testing - I'm not sure if that function needs to be available on the server as well; if so it might just propagate the issue. Also if the build server isn't fixed yet I'd need to build and upload the release to github
You could try somehow getting World into that function, then just using World.isRemote in ifs so it doesn't even run the clientside code on the server while still being the same function.
Or FMLCommonHandler.instance().getSide() == Side.CLIENT.
Yeah. Not saying that it a "prefect" solution. But it fixed my crashes for now. The Mekanism developers knows more about how this function is intended to work. But thought i would share my fix :)
I'm also running into the same issue at the moment.
Correct me if I'm wrong but the problem and the crash results because of this line:
if(MekanismGeneratorsClient.enableAmbientLighting)
In the server configs enableAmbientLighting is not assigned because it's not required. In order to fix the problem just assign "MekanismGeneratorsClient.enableAmbientLighting = false" for servers, correct?
No. Not exactly. There would need to be released a fix as the config variable you're talking about is client side only and it would only be read in the client configuration.
I'm not saying assign it in the configs for the server. I'm saying assign it in the ServerProxy side. Thats why I said "MekanismGeneratorsClient.enableAmbientLighting = false" and not "B:EnableAmbientLighting=false"
Oh i understand. Maybe that would work. But in that case you have to make code changes anyway. If it's urgent i could upload my compiled quick fix for this... I think the license allows that, let me check.
I'm not saying assign it in the configs for the server. I'm saying assign it in the ServerProxy side. Thats why I said "MekanismGeneratorsClient.enableAmbientLighting = false"
Then you'd have issues with mobs spawning near because client would see the light and server wouldn't.
Well, still better than crash ;-)
Here is my temporary workaround. But keep in mind, this should only be used on the server as the client 1.7.10-7.1.2.155 works just fine.
http://halvors.org/downloads/Mekanism-1.7.10-7.1.2.jar http://halvors.org/downloads/MekanismTools-1.7.10-7.1.2.jar http://halvors.org/downloads/MekanismGenerators-1.7.10-7.1.2.jar
@ZeekDaGeek is (mostly) correct. The variable needed to be moved to the CommonProxy
, as the entire ClientProxy
class is stripped from the jar by FML on the server-side. Stripping the getLightValue
method as well would not crash, but would prevent desired server behaviour as it would presumably just use the super method from Block
on the server.
I'll get around to fixing it properly now, sorry it took so long (if anyone happens to be an expert on the Kinetic Theory of Gases and Statistical Mechanics and wants to do my problem sheets for me I'll have more time this term to work on Mekanism :wink:). Seriously though, updates may be a bit slow going over the next 8 weeks due to both us devs being pretty busy with other education-type things. Nothing much can be done about it, unfortunately, but I'll try and find time to fix major issues like this one.
See that you fixed this in commit 2ced2e3860eb17b8021a210944331a5af7cb6848. But seems you forgot to remove the "@SideOnly(Side.CLIENT)" from inside loadConfiguration() in MekanismGenerators.java. So there is refactor here, but the server would still crash.
There you go :-)
Turns out I make mistakes when I'm tired :P
Hi Im getting this erorr that when searching led me here:
Encountered an unexpected exception net.minecraft.util.ReportedException: Exception ticking world at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:631) ~[MinecraftServer.class:?] at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334) ~[lt.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547) ~[MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:396) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685) [li.class:?] Caused by: java.lang.IllegalArgumentException
---- Minecraft Crash Report ---- // There are four lights!
Time: 9/18/15 7:16 AM Description: Exception ticking world
java.lang.IllegalArgumentException at net.minecraft.util.WeightedRandom.func_76273_a(WeightedRandom.java:28) at net.minecraft.util.WeightedRandom.func_76271_a(WeightedRandom.java:60) at net.minecraft.world.SpawnerAnimals.func_77191_a(SpawnerAnimals.java:235) at net.minecraft.world.gen.ChunkProviderGenerate.func_73153_a(ChunkProviderGenerate.java:424) at net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:279) at net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1050) at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52) at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12) at net.minecraftforge.common.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:344) at net.minecraftforge.common.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:302) at net.minecraftforge.common.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:12) at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:126) at net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:101) at net.minecraft.world.gen.ChunkProviderServer.func_73154_d(ChunkProviderServer.java:199) at net.minecraft.world.World.func_72964_e(World.java:419) at net.minecraft.world.SpawnerAnimals.func_151350_a(SpawnerAnimals.java:32) at net.minecraft.world.SpawnerAnimals.func_77192_a(SpawnerAnimals.java:100) at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:161) at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:625) at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334) at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:396) at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)
-- Head -- Stacktrace: at net.minecraft.util.WeightedRandom.func_76273_a(WeightedRandom.java:28) at net.minecraft.util.WeightedRandom.func_76271_a(WeightedRandom.java:60) at net.minecraft.world.SpawnerAnimals.func_77191_a(SpawnerAnimals.java:235) at net.minecraft.world.gen.ChunkProviderGenerate.func_73153_a(ChunkProviderGenerate.java:424) at net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:279) at net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1050) at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52) at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12) at net.minecraftforge.common.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:344) at net.minecraftforge.common.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:302) at net.minecraftforge.common.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:12) at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:126) at net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:101) at net.minecraft.world.gen.ChunkProviderServer.func_73154_d(ChunkProviderServer.java:199) at net.minecraft.world.World.func_72964_e(World.java:419) at net.minecraft.world.SpawnerAnimals.func_151350_a(SpawnerAnimals.java:32) at net.minecraft.world.SpawnerAnimals.func_77192_a(SpawnerAnimals.java:100) at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:161)
-- Affected level -- Details: Level name: Technium All players: 1 total; [EntityPlayerMP['highshadow66'/786, l='Technium', x=2593.50, y=124.00, z=-1500.50]] Chunk stats: ServerChunkCache: 467 Drop: 0 Level seed: 5525599864617445540 Level generator: ID 05 - BIOMESOP, ver 0. Features enabled: true Level generator options: Level spawn location: World: (-408,64,1287), Chunk: (at 8,4,7 in -26,80; contains blocks -416,0,1280 to -401,255,1295), Region: (-1,2; contains chunks -32,64 to -1,95, blocks -512,0,1024 to -1,255,1535) Level time: 2784796 game time, 733516 day time Level dimension: 0 Level storage version: 0x04ABD - Anvil Level weather: Rain time: 159199 (now: false), thunder time: 72132 (now: false) Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false Stacktrace: at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:625) at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334) at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547) at fastcraft.K.a(F:21) at fastcraft.H.aq(F:157) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:396) at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)
-- System Details --
Details:
Minecraft Version: 1.7.10
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_60, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 1410727696 bytes (1345 MB) / 4080271360 bytes (3891 MB) up to 8375238656 bytes (7987 MB)
JVM Flags: 26 total; -Xmx8G -Xms4G -Xmn2048m -Xincgc -XX:+DisableExplicitGC -XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:+UseNUMA -XX:+CMSParallelRemarkEnabled -XX:MaxTenuringThreshold=15 -XX:MaxGCPauseMillis=10 -XX:GCPauseIntervalMillis=150 -XX:+UseAdaptiveGCBoundary -XX:-UseGCOverheadLimit -XX:+UseBiasedLocking -XX:SurvivorRatio=8 -XX:TargetSurvivorRatio=90 -XX:MaxTenuringThreshold=15 -XX:+UseFastAccessorMethods -XX:+UseCompressedOops -XX:+OptimizeStringConcat -XX:+AggressiveOpts -XX:ReservedCodeCacheSize=2048m -XX:+UseCodeCacheFlushing -XX:SoftRefLRUPolicyMSPerMB=20000 -XX:ParallelGCThreads=3
AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
IntCache: cache: 0, tcache: 0, allocated: 12, tallocated: 104
FML: MCP v9.05 FML v7.10.99.99 Minecraft Forge 10.13.4.1492 273 mods loaded, 273 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
UCHIJAAAA mcp{9.05} Minecraft Coder Pack
UCHIJAAAA FML{7.10.99.99} Forge Mod Loader
UCHIJAAAA Forge{10.13.4.1492} Minecraft Forge
UCHIJAAAA AM2-Preloader{0.0.2} AMCore
UCHIJAAAA appliedenergistics2-core{rv3-alpha-6} Applied Energistics 2 Core
UCHIJAAAA Aroma1997Core{1.0.2.15} Aroma1997Core
UCHIJAAAA CodeChickenCore{1.0.7.47} CodeChicken Core
UCHIJAAAA FR-CORE{1.0.3} Floatable Rails
UCHIJAAAA ivtoolkit{IvToolkit} 1.2
UCHIJAAAA MCVanillaTweaks{1.0} Mariculture - Vanilla Tweaks
UCHIJAAAA NotEnoughItems{1.0.5.118} Not Enough Items
UCHIJAAAA OpenComputers|Core{1.5.16.32} OpenComputers (Core)
UCHIJAAAA OpenEye{0.6} OpenEye
UCHIJAAAA technomCore{0.12.0A} Technomancy Core
UCHIJAAAA backpacks16840{3.0.4} [Backpacks!](zz-backpacks 1.7.10 - 3.0.4.jar)
UCHIJAAAA OpenModsCore{0.8} OpenModsCore
UCHIJAAAA
Server crash using the latest release (7.1.2)
Here is the crashlog: http://pastebin.com/fcWaKv23