mekanism / Mekanism

A mod for Minecraft
MIT License
1.4k stars 531 forks source link

UniCables cannot accept energy from UE machines. #235

Closed unpairedbracket closed 11 years ago

unpairedbracket commented 11 years ago

Found with AS reactor turbines. Probably exists in other places as well.

I think I know how to fix this (make TileEntityUniversalCable implement INetworkProvider and EnergyNetwork implement IElectricityNetwork) but I'll wait for @aidancbrady to finish modularising before I do anything.

aidancbrady commented 11 years ago

My plan was to simply implement IElectrical in TileEntityUniversalCable, this would be a tad easier than completely implementing the electricity network.

unpairedbracket commented 11 years ago

I'll assume you probably know UE better than me, given you wrote a lot of it, but I can't resist asking: will that work? It looks to me like TileEntityElectrical.produceUE() works out where to put its power using ElectricityHelper.getNetworkFromTileEntity() then transfers it using IElectricityNetwork.produce(). I'm guessing there must be some other way of doing it?

aidancbrady commented 11 years ago

It WOULD work, but you have just reminded me that this would be slightly less user-friendly than if we actually implemented IElectricityNetwork. Go ahead, I'm sure it will turn out well.

unpairedbracket commented 11 years ago

Argh, method names conflicting. I'll see if I can make it work by changing some names.

aidancbrady commented 11 years ago

Thanks! Closed :)