Flamethrower deals damage when PvP is turned off

mekanism / Mekanism

A mod for Minecraft

MIT License

1.39k stars 531 forks source link

Flamethrower deals damage when PvP is turned off #7892

Closed BloodInAs closed 8 months ago

BloodInAs commented 1 year ago

Issue description

Flamethrower deals damage when PvP is turned off

Steps to reproduce

No response

Minecraft version

1.20.1 (Latest)

(Neo)Forge version

47.2.1

Mekanism version

10.4.0 (Latest)

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

pupnewfster commented 8 months ago

I am unable to reproduce this. How are you disabling PVP? I tried setting it off in the server.properties and it functions as expected (doesn't do damage).

pupnewfster commented 8 months ago

While I couldn't reproduce, https://github.com/mekanism/Mekanism/commit/c17cf16b79a2b5d88cb7943fe6d733b6cf5c1ff9 does add an extra check related to this so hopefully that will cover whatever case you were running into.