mekanism / Mekanism

A mod for Minecraft
MIT License
1.34k stars 510 forks source link

Fission Reactor Showing Wrong Burn Rate After Removing Assemblies #8132

Closed UnknownSerhan closed 1 week ago

UnknownSerhan commented 1 week ago

Issue description

When we set a burn rate in a fission reactor then remove assemblies from it and then reform it at an assembly count lower than the burn rate we set, the reactor stats page does not recognize it and keeps showing the old burn rate we set even though it exceeds the max burn rate.

This reactor had 4 assemblies and burn rate was set to 4, then removed 3 assemblies and reformed the reactor. image

In short, if the set burn rate is greater than the max burn rate, clamp the set burn rate to the max burn rate.

Steps to reproduce

  1. Build a fission reactor and set a burn rate higher than 1.
  2. Remove assemblies from the reactor until you have less assemblies than the burn rate you had set.
  3. Reform the reactor, check the stats page. See that it still shows the old

Minecraft version

1.21 (Latest)

NeoForge version

21.0.30-beta

Mekanism version

Current Dev Branch (Manually Compiled, specify git commit hash)

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response