search

mekomsolutions / openmrs-module-initializer

The OpenMRS Initializer module is an API-only module that processes the content of the configuration folder when it is found inside OpenMRS' application data directory.
MIT License
23 stars 79 forks source link

O3-614: Added support for AMPATH Forms Translations. #191

Closed icrc-jofrancisco closed 1 year ago

icrc-jofrancisco commented 2 years ago

Support for loading AMPATH translation files using the initializer. The file will be saved as ClobDatatypeStorage in order to support multiple forms.

rbuisson commented 2 years ago

@icrc-jofrancisco , I guess the domain would be better named "Ampath Forms Translations"

Addtionally, could you make sure to provide the update in the readme?

gracepotma commented 1 year ago

Perhaps @ibacher could review this?

ibacher commented 1 year ago

Possible addition of an ad-hoc README for this new domain, others to weigh in as to this is overkill or not.

I actually think documenting this domain is crucial.

icrc-jofrancisco commented 1 year ago

Hi @ibacher @rbuisson @mks-d, I added some tests, changed some names and completed the readme files. I'm open to new suggestions or changes that might be needed.

Thanks,

rbuisson commented 1 year ago

@ibacher , didn't you mention that the AMPATH forms translation files should be attached to forms via a form resource?

ibacher commented 1 year ago

Code looks good... Not sure about the build failure...

rbuisson commented 1 year ago

@Ruhanga , are you able to figure why the GitHub Actions build is failing?

rbuisson commented 1 year ago

GitHub Actions seems to be failing to get the org.bahmni.module:bahmnicore-api:jar:0.93-1.1.0 dependency. If removing this dependency from your local Maven repo, you should face the same issue.

rbuisson commented 1 year ago

Adding this to pom.xml <repositories> section shall fix it.

        <repository>
            <id>mks-repo</id>
            <name>Mekom Solutions Nexus</name>
            <url>https://nexus.mekomsolutions.net/repository/maven-public</url>
        </repository>