search

mekomsolutions / openmrs-module-initializer

The OpenMRS Initializer module is an API-only module that processes the content of the configuration folder when it is found inside OpenMRS' application data directory.
MIT License
23 stars 77 forks source link

[#219] Add drug mapping line processor. #226

Closed mseaton closed 1 year ago

mseaton commented 1 year ago

This still needs updates to the README and release notes, and the unit test changes to the DrugsLoaderIntegrationTest fails due to the dependency on versions of core that does not have the bug fix I added. Those need to be figured out.

mseaton commented 1 year ago

@ibacher - I took your advice and put the tests related to the drug reference maps into the 2.3 submodule, and then made this submodule use the latest 2.3.6-SNAPSHOT version, rather than 2.3.0. I used 2.3 as this is the furthest back I backported this fix into core. This shouldn't impact validator, as validator hard-codes a specific 2.3.x version into it's own pom.

ibacher commented 1 year ago

@mseaton Any idea on the test failures? Looks disconnected, but I'm worried that we've added something strange here...

mseaton commented 1 year ago

Thanks @Ruhanga ! That's very odd, because it looks like github actions is using OpenJDK 1.8.362. I went so far as to create a vanilla Ubuntu 22.04 Docker container, install this exact temurin Java version, and build, and I was able to do so successfully, so I've been at a real loss as to what is going on in Github actions.

My suspicion has been that it isn't directly related to this PR/commit, but I haven't had any evidence to that. Are you saying that these errors are already existing in the codebase in the master branch and you have some fixes in place in another PR that will address them?