search

mekomsolutions / openmrs-module-initializer

The OpenMRS Initializer module is an API-only module that processes the content of the configuration folder when it is found inside OpenMRS' application data directory.
MIT License
23 stars 77 forks source link

Add new FhirContactPoints domain #253

Open mherman22 opened 10 months ago

ibacher commented 10 months ago

@mherman22 Is there no way to get this to work without shifting to 2.0.0 of the FHIR2 module? I would prefer to support older versions.

mherman22 commented 10 months ago

@mherman22 Is there no way to get this to work without shifting to 2.0.0 of the FHIR2 module? I would prefer to support older versions.

I was trying this out. I'm pushing it back to 1.11.0 however the challenge there has to do with the location type translator not being got as a bean i.e NoSuchBeanException

ibacher commented 10 months ago

It looks like we're going to need to make 2.6 the minimum version for the LoaderTest and probably the validator too for this to work. @Ruhanga Do you have an opinion on that? Otherwise, we maybe add something to the Loader to not try to run a domain if a valid version of a loader isn't available.

mherman22 commented 10 months ago

It looks like we're going to need to make 2.6 the minimum version for the LoaderTest and probably the validator too for this to work. @Ruhanga Do you have an opinion on that? Otherwise, we maybe add something to the Loader to not try to run a domain if a valid version of a loader isn't available.

Fyi, I have done this locally though it is now not loading the loader for QUEUE so I am still looking for a workaround around that.

Ruhanga commented 10 months ago

It looks like we're going to need to make 2.6 the minimum version for the LoaderTest and probably the validator too for this to work.

@ibacher, @mherman22 concerning the above, upgrading to OpenMRS Core greater than 2.4.0 might require refactoring on the part of the Validator to accommodate new changes + upgraded libraries on Core. This will consequently need some extensive testing of the Validator itself.

ibacher commented 9 months ago

First bit looks like we need to change the calls like:

executeChangelog("changelog", null);

To:

executeChangelog("changelog", (ChangeSetExecutorCallback) null);

In ConfigTester...

ibacher commented 2 months ago

@mks-d This PR adds support for a feature that allows mapping between OMRS Attributes and FHIR ContactPoints. It populates a table that we use in the FHIR2 module to map between them. So, if you have an attribute that represents something covered by FHIR's ContactPoints type (phone number, email, website, etc.) as either a PersonAttribute or standard OMRS attribute, it will show up in the FHIR2 output for Patient, Provider, Location, etc. in the appropriate semantic field rather than as an OMRS-specific extension.

mherman22 commented 2 months ago

@mherman22 Are you able to wrap up the necessary changes here?

On it