The OpenMRS Initializer module is an API-only module that processes the content of the configuration folder when it is found inside OpenMRS' application data directory.
MIT License
23
stars
79
forks
source link
#277 - CSV parser should save cached objects once file has been loaded. #278
The CSV parser should persist objects once files in a domain have been processed. Currently, there's a bug where the last Privilege isn't being persisted and this PR addresses it.
I have removed some Assertions in PaymentModesLoaderIntegrationTest as it references some attributes that have to be saved before.....We will work on refactoring the PaymentModeAttributeType domain
Description of what I changed
The CSV parser should persist objects once files in a domain have been processed. Currently, there's a bug where the last
Privilege
isn't being persisted and this PR addresses it.I have removed some Assertions in
PaymentModesLoaderIntegrationTest
as it references some attributes that have to be saved before.....We will work on refactoring the PaymentModeAttributeType domainIssue I worked on
see https://openmrs.atlassian.net/browse/O3-3972
Checklist: I completed these to help reviewers :)
[x] My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend
[x] I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.No? -> execute above command
[x] All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master