search

mekomsolutions / openmrs-module-initializer

The OpenMRS Initializer module is an API-only module that processes the content of the configuration folder when it is found inside OpenMRS' application data directory.
MIT License
23 stars 79 forks source link

[#284] - Support "dispositions" domain #285

Closed mogoodrich closed 3 weeks ago

mogoodrich commented 1 month ago

https://github.com/mekomsolutions/openmrs-module-initializer/issues/284

mogoodrich commented 1 month ago

Updated based on Mike's feedback, ready for re-review, pending results of build and test run.

mogoodrich commented 3 weeks ago

Thanks @mogoodrich. I believe this should work with the validator too, and so the relevant emrapi packages should be packaged with it. Is this something you've tried out already?

I don't know what your are talking about @Ruhanga , so probably not... :) Is there a Maven profile or something I need to trigger to run some sort of validation tests?

mogoodrich commented 3 weeks ago

I don't know what your are talking about @Ruhanga , so probably not... :) Is there a Maven profile or something I need to trigger to run some sort of validation tests?

Actually, @mseaton pointed out to me that the validator tests run on the PR and passed, so I think we are good?

mseaton commented 3 weeks ago

I think it looks ready to merge. @Ruhanga ?

Ruhanga commented 3 weeks ago

Actually, @mseaton pointed out to me that the validator tests run on the PR and passed, so I think we are good?

I apologize for the confusion @mseaton, @mogoodrich. There isn’t much that can simulate the validator in unit tests. What I was referring to was conducting a runtime test of the validator using a minimal configuration involving the dispositions domain, as outlined in the documentation.

mogoodrich commented 3 weeks ago

I apologize for the confusion @mseaton, @mogoodrich. There isn’t much that can simulate the validator in unit tests. What I was referring to was conducting a runtime test of the validator using a minimal configuration involving the dispositions domain, as outlined in the documentation.

Ah, got it @Ruhanga ... I confirmed that running the validator against the dispositions domain was failing because the validator pom.xml was missing an emrapi dependency. I added it and confirmed that things work.