[bug] Image Feed Is unclickable

Lalimec commented 2 weeks ago

Describe the bug

Generated images are unclickable. When i try to click on one some weird lightbox appear on the right, encapsulating the menu and moves with it. This behavior started after I updated my comfy. Many custom node packs having weird issues after the ui migration.

Reproduction

No response

Expected behavior

No response

Operating System

Linux

Comfy Mode

In a custom virtual env (venv, virtualenv, conda...)

Console output

ComfyUI Front-end version: 1.2.60
:8188/favicon.ico:1 

       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this error
:8188/api/userdata/workflows%2F.index.json:1 

       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this error
api.ts:243 Unhandled message: {"type": "crystools.monitor", "data": {"cpu_utilization": 2.5, "ram_total": 33292865536, "ram_used": 9159053312, "ram_used_percent": 29.0, "hdd_total": 1040820109312, "hdd_used": 728502808576, "hdd_used_percent": 70.0, "device_type": "cuda", "gpus": [{"gpu_utilization": 0, "gpu_temperature": 27, "vram_total": 24146608128, "vram_used": 10801905664, "vram_used_percent": 44.7346708355046}]}} Error: Unknown message type crystools.monitor
    at WebSocket.<anonymous> (api.ts:238:23)
(anonymous) @ api.ts:243Understand this warning
comfy_shared.js:66 ℹ️ Initializing our mardown converter
comfy_shared.js:66 ℹ️ Skipping Coordinates To String (mtb) doesn't have a description, skipping...
comfy_shared.js:66 ℹ️ Setting up dynamic connections for class ComfyNode extends LGraphNode {
      static {
        __name(this, "ComfyNode");
      }
      static comfyClass = nodeData.name;
      // TODO: change to "title?" once litegraph.d.ts has been update…
comfy_shared.js:66 ℹ️ Skipping Interpolate Clip Sequential (mtb) doesn't have a description, skipping...
5comfy_shared.js:66 ℹ️ Setting up dynamic connections for class ComfyNode extends LGraphNode {
      static {
        __name(this, "ComfyNode");
      }
      static comfyClass = nodeData.name;
      // TODO: change to "title?" once litegraph.d.ts has been update…
comfy_shared.js:66 ℹ️ Skipping Batch Float Math (mtb) doesn't have a description, skipping...
comfy_shared.js:66 ℹ️ Setting up dynamic connections for class ComfyNode extends LGraphNode {
      static {
        __name(this, "ComfyNode");
      }
      static comfyClass = nodeData.name;
      // TODO: change to "title?" once litegraph.d.ts has been update…
comfy_shared.js:66 ℹ️ Skipping Load Vit Matte Model (mtb) doesn't have a description, skipping...
comfy_shared.js:66 ℹ️ Skipping Generate Trimap (mtb) doesn't have a description, skipping...
comfy_shared.js:66 ℹ️ Skipping Apply Vit Matte (mtb) doesn't have a description, skipping...
3comfy_shared.js:66 ℹ️ Setting up dynamic connections for class ComfyNode extends LGraphNode {
      static {
        __name(this, "ComfyNode");
      }
      static comfyClass = nodeData.name;
      // TODO: change to "title?" once litegraph.d.ts has been update…
components-manager.js:769 Empty components: policy ignored
comfy_shared.js:66 ℹ️ Enabled DEBUG mode
reroute.js:75 Uncaught (in promise) undefinedUnderstand this error
:8188/api/userdata/workflows%2F.index.json:1 

       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this error
groupNode.ts:370 Skipping virtual node Integer when building group node cemil::Inpaint Masked Only
getNodeDef @ groupNode.ts:370Understand this warning
:8188/extensions/ComfyUI_smZNodes/js/exif.js:1 

       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this error
prompt_service.js:117 'execution_start' fired before prompt was made.
(anonymous) @ prompt_service.js:117Understand this warning

Additional context

No response

melMass commented 2 weeks ago

Thanks for the report, I will fix it but the imageFeed wasn't updated for the new UI given we now have an equivalent builtin. I am working on a panel to list inputs and outputs in #193 (check the video preview there)

Btw it should be disabled by default now, unless it isn't you can do it yourself in the settings:

Lalimec commented 2 weeks ago

neat idea! not being able to see the previous inputs was such a drag. though this still has some work to do i guess?

Lalimec commented 2 weeks ago

ok, i wasnt able to find the "equivalent builtin" you were talking about but its the history tab i guess. new ui had some issues so i didnt bother to switch to that, good to know though thanks.

melMass commented 2 weeks ago

though this still has some work to do i guess?

Yes it's more a POC for now, only tested on windows I will merge it once I properly tested other platforms (should be this week)

you were talking about but its the history tab i guess

Yep you're right it's not an equivalent, I will check for a fix of the feed later today or tomorrow

Lalimec commented 2 weeks ago

no rush, keep up the good work much appreciated! Also, are you going to show the generations from previous sessions, or just the latest ones? Someway of browsing in the output/input folder would be great but thats a different job i guess.

melMass commented 2 weeks ago

Someway of browsing in the output/input folder

The first task in #193 (the poc we talked about earlier) does load everything from both input/outputs And the feed only the current session and there is a button to fully reload the current session history images

melMass / comfy_mtb