Question: Additional Note Attributes ?

[JohnTruety]

Is there any way to extend the Note class with additional attributes (i.e. Tracknumber) ? Thank you for your help.

[melanchall]

First of all, please describe your scenario. How do you get notes? midiFile.GetNotes()?

[JohnTruety]

How do you get notes? midiFile.GetNotes()? Yes

I need it in a sequencer application only for internal use. It should not be written to a midi file.

[melanchall]

Well, there is no simple way but workaround exists. First, create this class:

private sealed class TimedEventWithTrackChunkIndex : TimedEvent
{
    public TimedEventWithTrackChunkIndex(MidiEvent midiEvent, long time, int trackChunkIndex)
        : base(midiEvent, time)
    {
        TrackChunkIndex = trackChunkIndex;
    }

    public int TrackChunkIndex { get; }

    public override TimedEvent Clone()
    {
        return new TimedEventWithTrackChunkIndex(Event, Time, TrackChunkIndex);
    }
}

And now you nedd to collect notes in this way:

var notes = midiFile
    .GetTrackChunks()
    .SelectMany((c, i) => c
        .GetTimedEvents()
        .Select(e => new TimedEventWithTrackChunkIndex(e.Event, e.Time, i))
        .GetObjects(ObjectType.Note))
    .Cast<Note>()
    .OrderBy(n => n.Time)
    .ToArray();

To get track chunk index from a note, use this:

var trackChunkIndex = ((TimedEventWithTrackChunkIndex)note.GetTimedNoteOnEvent()).TrackChunkIndex;

[JohnTruety]

Fantastic. Many many thanks. And lot of thanks for your great library!!

[melanchall]

Thanks for using the library :)

Also since you're not the first person who asked me to solve the same task, I'll try to implement an easier way for that. So please don't close the issue.

[melanchall]

:rocket: 6.1.0 version is released now!

Now the second code snippet can be simplified to this:

var notes = midiFile
    .GetNotes(new NoteDetectionSettings
    {
        TimedEventDetectionSettings = new TimedEventDetectionSettings
        {
            Constructor = d => new TimedEventWithTrackChunkIndex(d.Event, d.Time, d.EventsCollectionIndex)
        }
    });

Thanks for using the library!

[JohnTruety]

Great J

Thanks for your help!

Von: Maxim Dobroselsky @. Gesendet: Montag, 16. Mai 2022 13:33 An: melanchall/drywetmidi @.> Cc: JohnTruety @.>; Author @.> Betreff: Re: [melanchall/drywetmidi] Question: Additional Note Attributes ? (Issue #175)

🚀 6.1.0 version is released now!

Now the second code snippet can be simplified to this:

var notes = midiFile

.GetNotes(new NoteDetectionSettings

{

    TimedEventDetectionSettings = new TimedEventDetectionSettings

    {

        Constructor = d => new TimedEventWithTrackChunkIndex(d.Event, d.Time, d.EventsCollectionIndex)

    }

});

Thanks for using the library!

— Reply to this email directly, view it on GitHub https://github.com/melanchall/drywetmidi/issues/175#issuecomment-1127557852 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKSCK4UWOCYWCR2UHRA2MLVKIW7FANCNFSM5UOBSFKA . You are receiving this because you authored the thread.Message ID: @.***>