search

melange-community / melange-fetch

Fetch bindings for Melange
MIT License
203 stars 53 forks source link

Remove bs-platform as peerDep #36

Closed yawaramin closed 4 years ago

yawaramin commented 4 years ago

Since it's already a devDep.

thecotne commented 4 years ago

it was correct actually since in compiled js it needs access to bs-platform https://github.com/reasonml-community/bs-fetch/blob/master/lib/js/src/Fetch.js#L3 so if someone wants to use that from js they need bs-platform for it to work

glennsl commented 4 years ago

Peer dependencies aren't installed automatically. They're considered optional and you have to manually add bs-platform as an explicit dependency to your project, so the only consequence of this should be that you won't get any warning if it doesn't satisfy the constraint.