melange-re / melange

A mixture of tooling combined to produce JavaScript from OCaml & Reason
https://melange.re
Other
846 stars 52 forks source link

Js__Js_xxx.t appears on type-errors and hovering #1154

Open davesnx opened 4 months ago

davesnx commented 4 months ago

Since we wrap melange.js there's an unfortunate side-effect of dune being wrapped by using a module name with like (JsJs_date) for all modules inside Js like (js_date.ml).

It's very convenient to use wrapped modules when you don't want to expose a bunch of modules to the top-level, but since Js isn't meant to be opened at the top I would argue that it's better if we keep it unwrapped for the sake of having better error messages.