search

melanierichards / just-build-websites

Some ideas for websites you can build!
MIT License
1.3k stars 116 forks source link

Added time calculator idea #1

Closed thadseaver closed 8 years ago

thadseaver commented 8 years ago

I'm a noob with Github so hopefully I did everything right. Everything seemed to go OK. Please don't hesitate to critique.

Thad

melanierichards commented 8 years ago

Thanks @thadseaver! My only feedback is to change the markdown for the headings so that they match the style here: https://help.github.com/articles/basic-writing-and-formatting-syntax/ (## etc only appears before the text, not after). Sorry for not having that in the contribution guidelines, but thanks for helping me to make those better! :P

thadseaver commented 8 years ago

@melanierichards Syntax has been fixed. Markdown Pad, my editor, formatted those headings for me. I'll have to keep an eye on that.

No need to apologize. Thanks for letting me contribute! :)

melanierichards commented 8 years ago

Thanks @thadseaver, merged!!

thankyou

FYI, I "squashed" the commits in your pull request when I merged the PR, that basically takes the smaller, more granular commits and creates one complete "idea" commit for the work that you contributed. That will make it a bit easier to review the history of the project. :]

thadseaver commented 8 years ago

Alright! :+1: