search

melanieseltzer / es6-all-the-things

Collection of ES6 goodies for next-level dev 🤓💻
https://melanieseltzer.github.io/es6-all-the-things/
207 stars 23 forks source link

Rephrase for-of #11

Open enko opened 6 years ago

enko commented 6 years ago

https://github.com/melanieseltzer/es6-all-the-things/blob/e4ccd9dc111c8c630ca38bd314c69740ce74ec50/src/data/index.js#L126

I think this phrase would be better:

Can be used for arrays and any object/class that implements Symbol.iterator. Able to use break and continue.

Reason: I think spreading knowledge of Symbol.iterator, is helping people to get a deeper understanding of the JavaScript environment they are working in.

I would have opened a pull request, but I'm not sure if I can use Markdown in the info element.

melanieseltzer commented 6 years ago

I like 👍

Have just added the ability to accept plain HTML in the info key in src/data/index.js, it would look something like:

info:
    'Blah blah <a href="https://link.com" target="_blank">Link name<a> blah blah',

Feel free to make a PR (or do you want me to just add it? I don't mind).