search

melanke / Watch.JS

watch the changes of any object or attribute
Other
2.14k stars 219 forks source link

Added recursive unwatching to the unwatchAll method #68

Closed oliver-moran closed 10 years ago

oliver-moran commented 10 years ago

watch(obj, fun) watches all of the descendants of an object. unwatch(obj, fun) however only unwatches the children of an object (i.e. grandchildren are still watched). This fix unwatches all of the descendants of a object.

swlasse commented 10 years ago

Is there a plan for when this is to be merged into master?

swlasse commented 10 years ago

Thanks @melanke

melanke commented 10 years ago

@swlasse, Thank you.

And thanks @oliver-moran for the improvement.

Listen, I know I am not giving this project the attention it deserves, it is because I am really busy with a lot of other things, so I will trust you guys to help me, doing pull requests. If you want my permission to handle this project just ask me.