search

melato / gpx

Classes for reading and writing GPX files
3 stars 0 forks source link

Error in GPX.maxSpeed() #1

Open trigchen opened 8 years ago

trigchen commented 8 years ago

GPX.maxSpeed() is same as GPX.duration().

melato commented 8 years ago

Yes, you are right. It turns out I never used it. I'd rather remove it because it's not clear what it should do. Speed can be calculated in two different ways: a) The GPX track waypoints may have a speed property, as a GPX extension. b) By dividing the difference in distance over the difference in time from the previous point. What do you expect maxSpeed() to do?

trigchen commented 8 years ago

The b) should be OK. I've cloned your git repositories(gpx, gps, xml) and made some modifications. Please see https://github.com/trigchen/gpx.

Best regards,

Trig

2016-06-26 23:24 GMT+08:00 melato notifications@github.com:

Yes, you are right. It turns out I never used it. I'd rather remove it because it's not clear what it should do. Speed can be calculated in two different ways: a) The GPX track waypoints may have a speed property, as a GPX extension. b) By dividing the difference in distance over the difference in time from the previous point. What do you expect maxSpeed() to do?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/melato/gpx/issues/1#issuecomment-228606547, or mute the thread https://github.com/notifications/unsubscribe/ARSfZnKldh2-YNEDZi4PsNmjb9k5Q3mXks5qPpnLgaJpZM4I-hdz .