search

melbahja / got

Got: Simple golang package and CLI tool to download large files faster 🏃 than cURL and Wget!
MIT License
714 stars 45 forks source link

added simple progress status #19

Closed mpldr closed 4 years ago

mpldr commented 4 years ago

I've added a simpler progress status report that should be easier on the eyes for everyday use.

mpldr commented 4 years ago

I've also made a version with a spinner but I'm not sure if this would be preferable. with-spinner.diff.txt

mpldr commented 4 years ago

tests are failing because therer is an issue in download_test.go:194: Corrupted file

not my fault though

mpldr commented 4 years ago

Just tried it and it works just fine on Windows and Linux.

The checksum of the downloaded file matches the checksum provided by http://www.ovh.net/files/sha1sum.txt

melbahja commented 4 years ago

The new progress looks very nice you can make it the default. and remove the old one and simple flag. and add build tags on variables_* files like on darwin file:

// +build darwin
melbahja commented 4 years ago

The Corrupted file test error it just because I've used go.mod file for testing :facepalm:, I will fix it

mpldr commented 4 years ago

I used the version without the spinner. If you want to use it the patch should be easy to apply after some modification.

melbahja commented 4 years ago

Looks nice thank you :), I will fix the test errors before merge.