Optimizations and refactoring

renbou commented 3 years ago

Hi! Loved the idea of this tool, so I decided to contribute some improvements:

Some simple refactoring
Fixed bug where content-disposition name wouldn't actually be used for d.name (since d.name was set only once, then even if Info returned a valid name, it wouldn't be used in the resulting filepath)
Removed usage of redundant HEAD request to determine range support, now only GET is used since its more reliable and makes the code simpler
Optimized the concurrent file writing by a lot, now all goroutines write to a single file concurrently using WriteAt (which is documented to be concurrent), so no temporary files are used and no merge is needed, again simplifying the code

Not sure why, but the test workflows on go 1.14 windows are sometimes not passing (even though they are marked as ok, some unrelated errors are thrown by go vet, which makes the github CI workflow get marked as failed)

Didn't measure the optimizations on a server with good internet, but my local testing seems to save around 3+ seconds each time since we avoid file copying

renbou commented 3 years ago

The optimizations done here (concurrently writing to single file) also fix what has been mentioned in #32 (slow writing to disk), since now the fastest way possible is used

renbou commented 3 years ago

Also fixes all problems described in #29!

renbou commented 3 years ago

This is what I was talking about - the tests pass as OK, but the action fails. Maybe it's time to update the actions to run tests on 1.16 and 1.17?

melbahja commented 3 years ago

it's fails only on 1.14.x windows, i think the tests gonna pass on 1.16 and 1.17

melbahja commented 3 years ago

Thank you for your valuable pr

melbahja / got

Optimizations and refactoring #35