Crashes on node 14.x - Githubissues

melchor629 / node-flac-bindings

Nodejs bindings to libFLAC

ISC License

17 stars 1 forks source link

Crashes on node 14.x #25

Closed melchor629 closed 3 years ago

melchor629 commented 3 years ago

Due to https://github.com/nodejs/node-addon-api/issues/799 , using shared buffers causes crashes on node 14.x (and probably 15.x as well). As it seems this is not going to be fixed soon, a workaround should be provided (maybe trying to do the work using the C API directly...) for node 14.x

melchor629 commented 3 years ago

Screenshot https://github.com/nodejs/node/releases/tag/v14.0.0

This seem to be the reason...

melchor629 commented 3 years ago

Found a way to avoid crashes by using (when required) detach operation on buffers, so they can be re-used many times. No errors on CI nor local tests, for now...