meld-cp / obsidian-encrypt

Hide secrets in your Obsidian.md vault
MIT License
625 stars 36 forks source link

Closing other notes on encrypt/decrypt #161

Open ileio opened 6 months ago

ileio commented 6 months ago

When few notes are opened, when encryption/decryption applied to one of them - only encrypted note left, other being closed

meld-cp commented 6 months ago

Hi @ileio , which version of the plugin are you seeing this with?

ileio commented 6 months ago

Version 2.3.7

meld-cp commented 6 months ago

Does it still happen with 2.4.0-beta?

ileio commented 6 months ago

Yes, still happening. But now it's closing only one note. And from encrypted note I can go back to closed note by pressing arrow back :)

Forgot to mention - I'm using Obsidian with latest MacOS, maybe it's worth to know.

meld-cp commented 6 months ago

Hi @ileio, could you run me through the steps to reproduce this issue?

Is it: you have multiple notes open, then from the file navigation, you click on one of the notes and choose encrypt/decrypt..?

ileio commented 6 months ago

Hi, It's very simple: open two notes at once, encrypt (or decrypt if already encrypted) one of then - second note will be closed)

meld-cp commented 6 months ago

How do you trigger the encrypt or decrypt? Command pallet?

ileio commented 6 months ago

Haven't tried command pallet actually. I've tried right-press on notes name at sidebar or press on three dotes at the top right corner, then "Encrypt note". Same result for both ways

meld-cp commented 6 months ago

Thanks, I'll see if I have time this weekend to take a look at it 👍

ileio commented 6 months ago

Thank you :)

meld-cp commented 6 months ago

hey @ileio , try 2.4.0-beta.2

The target note still needs to be closed and reopened, but at least any other notes should still stay open.

ileio commented 6 months ago

Now everything is fine - target note indeed closes and reopens and other notes are don't touched. Thanks!

meld-cp commented 6 months ago

Awesome, thanks for testing 🙂