meld-cp / obsidian-encrypt

Hide secrets in your Obsidian.md vault
MIT License
607 stars 36 forks source link

Markdown inside encrypted notes #48

Closed meld-cp closed 1 year ago

meld-cp commented 1 year ago

Please check version v2.0.0 and see how you get on with the new standalone encrypted note setup.

OK honeymoon's over. Can we have Markdown inside encrypted note? 🙏🙏🙏 pretty pretty pretty please?

Originally posted by @mardoqueo in https://github.com/meld-cp/obsidian-encrypt/issues/31#issuecomment-1305585083

meld-cp commented 1 year ago

That was the initial intent, and would be awesome, but unfortunately, I ran into corruption issues with my implementation when switching between markdown views (reading, edit, source, live preview etc).

So we are stuck with plain text until I can work out how to do it 🤔

Gewerd-Strauss commented 1 year ago

Hmm, maybe restrict it to one of the three (edit/rendered/lp) to begin with?

Preferably lp, but that might also be the most complicated probably. Nonetheless it is a neat feature, albeit the inability to link to the file properly is the biggest setback (well you can, but it is not given as a suggestion when linking, so you actually must know the entire name).

meld-cp commented 1 year ago

Absolutely, locking to live preview would be great, but I'm yet to figure out a way to get Obsidian to stay in that mode. I might have to ask around.

Re: the linking, do you mind logging a separate issue for that?

deusnovus commented 1 year ago

+1 for that feature, please! Also yes, I believe locking it to live preview to avoid corruption issues might be a great idea. Has there been any progress on that?

meld-cp commented 1 year ago

Improvements added to this issue in v2.1.1.

There's still a lot missing to get it to the level of a normal note.

It's nice having some MD in the notes now. Please test! 👍

deusnovus commented 1 year ago

I just updated to v2.1.1, but I haven't noticed any changes compared to the version before that... (no MD or styling of any kind)

meld-cp commented 1 year ago

I'm not by my desktop right now, but here's an example of how it works from my phone.

It's a similar setup for desktops, you need to switch from source view to reading view to see the formatting (There's a new setting to set your default)

It's not as feature rich as what you'll be used to from a normal note, but I'm happy we can now have formatted encrypted notes.

https://user-images.githubusercontent.com/18450687/230721588-0c47c90e-2408-442b-b66d-744ef8d72754.mp4

deusnovus commented 1 year ago

Okay, I managed to get things working properly! Fantastic work, it's a great start indeed! Now, I wonder if there's any way for the encrypted notes to be aligned like the default Obsidian notes in the center of the editing space, as opposed to the far left...

meld-cp commented 1 year ago

I'll close this for now, there're still some things missing but aside from duplicating every feature from the normal note view, I don't have an easy way to implement them.

So, I'll rely on people creating issues and going from there.