search

meld-cp / obsidian-encrypt

Hide secrets in your Obsidian.md vault
MIT License
585 stars 36 forks source link

Pressing "Enter" to confirm password doesn't encrypt selected text #7

Closed meld-cp closed 3 years ago

meld-cp commented 3 years ago

@barbwire08 I've created a new issue here so we can track this separately

Ref: https://github.com/meld-cp/obsidian-encrypt/issues/4#issuecomment-808684245

meld-cp commented 3 years ago

I can't look at the code right now, but I wonder if it's not recognising the Enter key on the numpad (vs the Return key near Shift) on a standard desktop keyboard.

I can test this out later.

barbwire08 commented 3 years ago

Thank you very much meld-cp. I just tried encrypting using the Return key near the Shift and it worked! Thank you again.

On Mon, Mar 29, 2021 at 4:51 AM meld-cp @.***> wrote:

I can't look at the code right now, but I wonder if it's not recognising the Enter key on the numpad (vs the Return key near Shift) on a standard desktop keyboard.

I can test this out later.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meld-cp/obsidian-encrypt/issues/7#issuecomment-808931902, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATNP56Q3KAFAIUNVRSZHDQLTF5UBZANCNFSM4Z6IAA7A .

meld-cp commented 3 years ago

No problem, thanks for logging the issue, it will be fixed in the next release. 👍

meld-cp commented 3 years ago

Fixed in v1.3.2