meldsolutions / Meld-Google-Sitemaps

Generates Google Sitemaps for Mura CMS websites
GNU General Public License v2.0
8 stars 9 forks source link

Inheriting Exclude Setting Not Working As Expected #38

Closed bradmarshall closed 6 years ago

bradmarshall commented 7 years ago

There seems to be some unexpected behaviour in the way pages inherit their exclude setting from parent pages. We had a system where we installed the plugin on an existing site and attempted to inherit the exclude setting on an entire branch of nodes by setting Exclude from Sitemap to true on a folder and letting the setting inherit down to subfolders and subpages without actually touching the sub nodes at all. To our surprise, these sub items were still getting outputted to our sitemap!

I believe this has something to do with the fact that these were old, already published nodes and did not have extended attribute values set by default (typically an extended attribute is set to a blank string until the node is published). The issues seems to lie in the getInherit() function. Shouldn't that function have excluded our sub-items by default due to inheritance settings?

Also, our top-level folder had restricted access settings on it such that you needed to be logged into to view any of the sub-nodes from the front end. Does the sitemap generator take any permissions/access into account when outputting nodes to a sitemap?

Plugin version 3.0.0 Mura version 6.2.6386