search

melenaos / FileSystemSafeWatcher

Extends the FileSystemWatcher to trigger the events only when the file is ready for read
Apache License 2.0
34 stars 13 forks source link

Possible Bug #1

Closed InteXX closed 6 years ago

InteXX commented 6 years ago

There appears to be a bug in the (rather complex) logic statement found at LIne 66. Line 68 contains a single &. Should this not be a double?

melenaos commented 6 years ago

You are right, I haven't noticed it.

It's not actually a bug because a&b == a&&b for boolean variables.

But I will fix that to fix the harmony on that.

InteXX commented 6 years ago

Gotcha. It popped up for me because I converted it to VB.

Any hint about what the not-implemented WaitForChanged overloads are for?

melenaos commented 6 years ago

WaitForChanged Could be used when you do something and you wait for a filechange to occur.

Instead of getting the changed event from a Event you can just use this function to wait for some milliseconds and get the event.

Unfortunately i haven't implemented it yet nor i will in the near future. I am working in a completely different field now and I won't use the FileSystemSafeWatcher any more.

InteXX commented 6 years ago

@melenaos

That's fine, I was just curious.

Good work on this. I can see you put a lot of thought into it at the time.

InteXX commented 6 years ago

@melenaos

Are you saying you've left programming?

melenaos commented 6 years ago

No, I stopped working on fat-clients and start working on the web so no more file-watchers or Serial port readers for my self!

InteXX commented 6 years ago

I don't blame you on those serial port readers...

What a pain in the neck :-)

melenaos commented 6 years ago

Yes!! Custom protocols and poorly documentation is not a great way of starting a new project.

InteXX commented 6 years ago

...and don't forget Microsoft bugs that they haven't fixed in years!

InteXX commented 6 years ago

Anyway, best of luck to you on your switch.

Thanks for all your hard work on this. It's saving me a bunch.

melenaos commented 6 years ago

Thanks!