Closed pisinr closed 7 years ago
Perfect, thanks
@melenaos Do you know how do I make sure that this count toward hacktoberfest?
I am not sure, as I read at the instructions it just need a pull request to be accepted. I have added hacktoberfest at the pull request, it might be needed. If you find out more on this please let me know.
Thank a lot!
This allows
data
key to be more extensible.then
method) that resolves to data array.In case of (3.) and (4.), this allows refreshing data or recalculating data.
So this will make ajax call on first render, but not on refresh:
While this will make new GET request on refresh
The function above is actually called with
function(this.settings, this)
. So you can share a single function to handle multiple punchcard.Other related changes include:
punchcard-loading
while the Promise is being resolved.punchcard-error
is the Promise fails.