search

meleu / RetroArch-problematic-cheevos

A place to put the savestates of games with cheevos problems when running in RetroArch and no problems in official emulators.
6 stars 10 forks source link

Some broken N64 achievements #30

Closed GameDragon2k closed 6 years ago

GameDragon2k commented 6 years ago

@meleu suggested I make a new issue for this. This is somewhat an extension of issue #23 .

As of now, any achievements that uses the flag "Add Source, Sub Source, or Add Hits" do not work on RetroArch. Two notable games that make use of these flags are Star Fox 64 and Pilotwings 64. These flags are currently exclusive to N64. All achievements that do not have these flags work fine to my knowledge.

@leiradel The source code for this can be found here. The files you may want to look at is RA_Achievement.cpp/.h and RA_Condition.cpp/.h.

leiradel commented 6 years ago

Yeah, I've already compared the implementations and they look equivalent. I'm starting to think there may be something wrong with the parser (see https://github.com/meleu/RetroArch-problematic-cheevos/issues/29).

GameDragon2k commented 6 years ago

Add Source implementation seems to be fine now. Once I verify Add Hits is working, I'll close this issue.

meleu commented 6 years ago

Really cool! But what changed? Were there any related changes in the core or RetroArch?

meleu commented 6 years ago

closing this issue.

@GameDragon2k feel free to reopen if you think it deserves to be opened.