search

melexis / sphinx-coverity-extension

Sphinx plugin to generate Coverity defects report or table in reStructuredText documentation. Coverity report is then personally styled while data integrity is guaranteed.
GNU General Public License v3.0
5 stars 2 forks source link

Fail more gracefully and do not block build #3

Closed Letme closed 6 years ago

Letme commented 6 years ago

When there is no connection or wrong data build is terminated. This seems like a wrong behavior as the plugin actually blocks any sphinx build if its blocks cannot be resolved. To fix this the whole try-except block is wrapped around connection items, which makes build just display the error, but still continue.

Tested with setting PC offline and building example documentation.

codecov-io commented 6 years ago

Codecov Report

Merging #3 into master will decrease coverage by 0.72%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   19.07%   18.35%   -0.73%     
==========================================
  Files           1        1              
  Lines         152      158       +6     
==========================================
  Hits           29       29              
- Misses        123      129       +6
Impacted Files Coverage Δ
mlx/coverity.py 18.35% <0%> (-0.73%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c46f562...4f6e078. Read the comment docs.