search

meleyal / backbone-on-rails

A simple gem for using Backbone.js with Rails.
MIT License
805 stars 125 forks source link

Add json2 #32

Closed garrensmith closed 12 years ago

garrensmith commented 12 years ago

Should this not come packaged with json2.js since that is a requirement for using Backbone? I just got bitten by this, I assumed that this gem would handle all dependancies for backbone.

Other than that thanks for a really useful gem.

meleyal commented 12 years ago

It seems json2 is only required for browsers without native JSON support (lt-ie8 according to http://caniuse.com/#feat=json), so I'd rather not include this by default.

But I'll add a note to the readme saying it's not included.

garrensmith commented 12 years ago

Ok cool, I think adding it to the readme should at least warn people. Thank.

On 05 Sep 2012, at 9:40 PM, William Meleyal notifications@github.com wrote:

It seems json2 is only required for browsers without native JSON support (lt-ie8 according to http://caniuse.com/#feat=json), so I'd rather not include this by default.

But I'll add a note to the readme saying it's not included.

— Reply to this email directly or view it on GitHub.