search

melff / mclogit

mclogit: Multinomial Logit Models, with or without Random Effects or Overdispersion
http://melff.github.io/mclogit/
22 stars 4 forks source link

Possible typo in mblogit code #13

Closed DarwinAwardWinner closed 3 years ago

DarwinAwardWinner commented 3 years ago

In the code in mblogit for dealing with the groups argument, there seems to be a typo on line 124:

gf <- as.formula(rf)

As far as I can tell, the variable rf should never be defined at this point in the code (since it is only defined in a mutually exclusive branch of the if/else), so this line will always throw an error. Presumably the correct line is:

gf <- as.formula(gf)
melff commented 3 years ago

Thans for reporting! Fixed in 6fdf9f78f19d36f129e3e5fbfe54b4953fd35886 (release 0.8.6.4.1).