melff / memisc

Tools for Managing Survey Data, Creating Tables of Estimates and Data Summaries
https://melff.github.io/memisc
45 stars 8 forks source link

Variables with duplicate labels cause an infinite loop in xtabs #39

Closed jciconsult closed 5 years ago

jciconsult commented 5 years ago

The Statcan SPSS file that I am processing (community health survey) has two variables with duplicate labels. If these variables are in the dataset that is used a source for xtabs, even if the variables are not in the xtab, there is an error message about factor problems and R hangs in a loop).

melff commented 5 years ago

Have you tried running this with the most recent release on Github? Anyway, without example data, I am unable to identify and fix the but that may cause this issue.

jciconsult commented 5 years ago

The new code does not cause a problembin the machine at my farm. I am going to update all my machines. I am back in Toronto and have not done that here but will confirm before and after results. Could you please identify the function that gives me the name of variables with duplicate lists. Thanks in advance.

from Paul Jacobson's mobile device

On Sat., Jan. 19, 2019, 17:47 Martin Elff <notifications@github.com wrote:

Have you tried running this with the most recent release on Github? Anyway, without example data, I am unable to identify and fix the but that may cause this issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/melff/memisc/issues/39#issuecomment-455821647, or mute the thread https://github.com/notifications/unsubscribe-auth/AUAF-hSAKSu_YQj82C_je-HR-v9MwboBks5vE6CYgaJpZM4Z8TVw .

melff commented 5 years ago

?duplicated_labels

jciconsult commented 5 years ago

In version 0.99.14.02 on the Toronto machine , this code seems to take an inordinate amount of time. cchs1516.ds<-readRDS("cchs1516_ds.Rds") xtabs(wts_m~incdvrca,data=cchs1516.ds) after a message about duplicate labels . I am able to hit the stop command to get out of it. I was not able to do that on the farm machine. The survey is quite interesting and large. The issue may have just been the scale. It is the Canadian Community and Health Survey.

I thought that I had send you the link. I will send it to your email but not to git hub.

On Sat, Jan 19, 2019 at 5:56 PM Martin Elff notifications@github.com wrote:

Closed #39 https://github.com/melff/memisc/issues/39.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/melff/memisc/issues/39#event-2084729633, or mute the thread https://github.com/notifications/unsubscribe-auth/AUAF-jxjDaogXZ8IBjL5hW2BO6577R_Oks5vE6KCgaJpZM4Z8TVw .

-- Paul M. Jacobson Jacobson Consulting Inc. 80 Front Street East, Suite 720 Toronto, Ontario M5E 1T4 Voice: +1(416)868-1141 Email: pmj@jciconsult.com Past President CABE 2017-2019