Closed mingaldrichgan closed 9 months ago
@melianmiko Is "secondary_widget"
intended to be listed as a common file, or was that just for testing purposes?
@melianmiko Is
"secondary_widget"
intended to be listed as a common file, or was that just for testing purposes?
I added them in an experiment, and forgot to delete.
zmake.json
already has a"common_files"
config, but it has not been used. Instead,project_build.py
has a hardcoded list of common files:["README.txt", "LICENSE.txt", "README", "LICENSE", "secondary-widget"]
that is used in thecommon_files
handler. This PR moves the hardcoded list into the"common_files"
config and uses the latter in thecommon_files
handler.zmake.json
since the previous default was"common_files": []
. Feel free to suggest better ways to handle this for backwards compatibility.package
andmake_zeus_pkg
handlers already exclude.DS_Store
andThumbs.db
, but the resulting packages do include.gitignore
and potentially other files that should be ignored, like source maps (ifuglifyjs
is called with--source-map
). This PR adds a"ignore_files"
config tozmake.json
and uses it in thepackage
andmake_zeus_pkg
handlers.zmake.json
files,"ignore_files"
defaults to[".DS_Store", "Thumbs.db"]
if not present inzmake.json
.zmake.json
also includes".gitignore"
since I cannot think of any reason for that to exist in the built package. - The existing substring logic (if ".DS_Store" in fn or "Thumbs.db" in fn
) is kept, just using the"ignore_files"
config instead. Wildcards are not currently supported.