search

melinath / django-daguerre

On-the-fly image manipulation for Django.
http://django-daguerre.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
85 stars 15 forks source link

cached adjusted images need to be cleared when a new area is defined for that image. #39

Closed vgpena closed 11 years ago

melinath commented 11 years ago

This is actually not entirely true. We only need to clear adjusted images that automatically use areas - fill and crop. The clearing needs to happen when an area is deleted, as well.

melinath commented 11 years ago

It might make sense to add a "uses_areas" attribute to adjustments so that you can figure out which ones to clear instead of just hard-coding it. This'll make sense in the context of making adjustments more extensible (see for example #20).

melinath commented 11 years ago

You should use the post_delete signal for clearing on deletion... that'll handle Area.objects.delete() and Area.delete() at the same time. But the Area.save() method should be fine for handling areas being defined or changed.

vgpena commented 11 years ago

addressed by #41

melinath commented 11 years ago

Resolved by e068e2a.