search

melinath / django-daguerre

On-the-fly image manipulation for Django.
http://django-daguerre.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
85 stars 15 forks source link

Drop support for PIL #53

Closed harrislapiroff closed 4 years ago

harrislapiroff commented 10 years ago

Django is dropping PIL support in favor of Pillow exclusively. We should too sometime.

harrislapiroff commented 10 years ago

I guess we've actually quietly done this, but we should still remove the weird as heck PIL imports. https://github.com/littleweaver/django-daguerre/blob/master/daguerre/adjustments.py#L8

We can remove those now, right?

melinath commented 10 years ago

Does Pillow not need those? I wasn't sure that was fixed. If so - yeah, let's remove them.

melinath commented 10 years ago

Django isn't dropping PIL support until 1.8, so we could alternately use their import fixes until then. But we might have had some bugs under PIL... I forget.

FTR, the proper import for Pillow is from PIL import <whatever>

harrislapiroff commented 10 years ago

Yeah, I think it's just the try and except with import Image stuff that was needed for PIL's bizarre installation process. But I'm happy to wait till 1.8 to remove them. They're not really causing any harm, just kinda ugly.