search

melinath / django-daguerre

On-the-fly image manipulation for Django.
http://django-daguerre.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
85 stars 15 forks source link

Improperly referenced grappelli image in css #69

Closed hamole closed 9 years ago

hamole commented 9 years ago

Came across this when trying to run the css through django-pipeline. There is a line in the areawidget.css that tries to load a png from grappelli as a background image.

https://github.com/littleweaver/django-daguerre/blob/0defbf67cf1c2708411ec99a16a79a7f1753af38/daguerre/static/daguerre/css/areawidget.css#L17

I think this should be included as a static file of daguerre.

Attached the image I believe it's trying to load. icons-s96d5c23000

harrislapiroff commented 9 years ago

I don't think we consider this a bug because the CSS that references that image only has any effect if Grappelli is installed. If Grappelli is not installed, those CSS declarations never get used and it doesn't matter that the image is not present. Is this causing specific problems in using django-pipeline? I'm not a django-pipeline user, so I'm not familiar with how it works.

harrislapiroff commented 9 years ago

My mistake. The image isn't working even with Grappelli installed. This is a bug after all. Looking into it.

melinath commented 9 years ago

@hamole 2.1.4 includes #71 and should fix the issue you were seeing.

hamole commented 9 years ago

Confirmed fixed, running collectstatic with 2.1.3

Post-processing 'daguerre/css/areawidget.css' failed!
ValueError: The file 'grappelli/images/icons-s96d5c23000.png' could not be found

With 2.1.4

Post-processed 'daguerre/css/areawidget.css' as 'daguerre/css/areawidget.3c0c043b3eed.css'
melinath commented 9 years ago

Thanks!