search

melinath / django-daguerre

On-the-fly image manipulation for Django.
http://django-daguerre.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
85 stars 15 forks source link

Don't alter images that don't need it (specifically re: resize) #73

Closed melinath closed 4 years ago

melinath commented 8 years ago

I don't know if this would be just a template tag feature or also in helpers, but. If an image is supposed to be resized and already is the size it will be, we should just copy the original file (or maybe just return the original file as the path?) The problem this would solve: jpeg artifacts on images that are already exactly the right size.

harrislapiroff commented 8 years ago

Probs in the helpers so this fix also captured the ajax feature, right? That's a thing, right? I can't remember.

melinath commented 4 years ago

Closing this one - we probably don't care, especially as images are getting larger and larger. If people need to avoid jpeg artifacts they should use png. And we shouldn't ever return the original image for security reasons - we should instead always be stripping exif data.