meliorence / react-native-image-gallery

Pure JavaScript image gallery component for iOS and Android with high-performance and native feeling in mind
715 stars 298 forks source link

Fix gesture responder binding issues causing errors in `onResponderGrant`. #150

Open AndrewSouthpaw opened 4 years ago

AndrewSouthpaw commented 4 years ago

Somehow the context is getting dropped some of the time, so that this becomes undefined inside ViewTransformer#onResponderGrant. Binding the methods to the instance fixes the issue.

We were seeing it inconsistently in production and could never repro the problem ourselves, but the errors went away once we added the binding.

It's unclear how it's only happening some of the time -- usually binding issues will become immediate apparent with React -- so my best guess is there's some detail inside the React Native system where the context can be dropped.