meliorence / react-native-render-html

iOS/Android pure javascript react-native component that renders your HTML into 100% native views
https://meliorence.github.io/react-native-render-html/
BSD 2-Clause "Simplified" License
3.48k stars 589 forks source link

allowFontScaling not working on <li> tag. #570

Open echagnas opened 2 years ago

echagnas commented 2 years ago

Decision Table

Good Faith Declaration

Description

Hi, I've just found a problem with "allowFontScaling".

The param "allowFontScaling" works fine with all text, but there is a problem with "ol" "li" tags. The text in the "li" works, but the "bullet" stay in the font size define by the OS.

For example the following <ol><li>first</li></ol> will show "1. first" but the "1" will be with a big font.

Perhaps there is a turnaround, but doesn't find it for the moment.

I've tried to use "tagsStyles" to change the "ol" or "li" fontSize, the text change but not the bullet. :(

React Native Information

info Fetching system and libraries information...
(node:69653) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
System:
    OS: macOS 12.4
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 566.98 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.17.6 - ~/.nvm/versions/node/v14.17.6/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.2.0 - ~/.nvm/versions/node/v14.17.6/bin/npm
    Watchman: 2021.11.15.00 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.2 - /usr/local/opt/ruby@2.5/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 23, 30, 31, 32
      Build Tools: 30.0.2, 30.0.3, 32.0.0
      System Images: android-29 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8512546
    Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.12 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2 
    react-native: 0.66.3 => 0.66.3 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

RNRH Version

6.3.1

Tested Platforms

Reproduction Platforms

Minimal, Reproducible Example

<ol><li>first</li></ol>

Additional Notes

No response

codal-mpawar commented 2 years ago

@jsamr @echagnas @laurynas @krystofcelba @fauzie811 any update on this facing same issue. Steps:

  1. setting -> display -> fonts change the font style
  2. open then app style will change and same as device.
jsamr commented 2 years ago

@codal-mpawar I don't have time to explore and fix this right now but I'll review PRs.

codal-mpawar commented 2 years ago

@jsamr Can you please look into and as soon as possible fixes. Thanks for fast response.